Review Request: (2/3) Add "Join Chat Room" button to the presence applet

Othmane Moustaouda othmane.moustaouda at gmail.com
Wed Aug 29 20:29:03 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104534/
-----------------------------------------------------------

(Updated Aug. 29, 2012, 8:29 p.m.)


Review request for Telepathy.


Changes
-------

Differences between the old ktp-contact-list/rooms-model.cpp and the new ktp-common-internals/KTp/Models/rooms-model.cpp are here: http://paste.kde.org/541466/
for join-chat-room-dialog.cpp here http://paste.kde.org/541472/


Description
-------

Moving join chatroom dialog from contact-list to common-internals to make possible its use also by the presence applet


This addresses bug 293207.
    http://bugs.kde.org/show_bug.cgi?id=293207


Diffs (updated)
-----

  KTp/Models/CMakeLists.txt e6a65b4e66902eb759352cd225fe67053e8a766d 
  KTp/Models/rooms-model.h PRE-CREATION 
  KTp/Models/rooms-model.cpp PRE-CREATION 
  KTp/Widgets/CMakeLists.txt 0dcf7c13ef7013afb94e3685f1925d59bece1833 
  KTp/Widgets/join-chat-room-dialog.h PRE-CREATION 
  KTp/Widgets/join-chat-room-dialog.cpp PRE-CREATION 
  KTp/Widgets/join-chat-room-dialog.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104534/diff/


Testing
-------


Thanks,

Othmane Moustaouda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120829/94370698/attachment.html>


More information about the KDE-Telepathy mailing list