<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104534/">http://git.reviewboard.kde.org/r/104534/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Othmane Moustaouda.</div>


<p style="color: grey;"><i>Updated Aug. 29, 2012, 8:29 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Differences between the old ktp-contact-list/rooms-model.cpp and the new ktp-common-internals/KTp/Models/rooms-model.cpp are here: http://paste.kde.org/541466/
for join-chat-room-dialog.cpp here http://paste.kde.org/541472/</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moving join chatroom dialog from contact-list to common-internals to make possible its use also by the presence applet</pre>
  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=293207">293207</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KTp/Models/CMakeLists.txt <span style="color: grey">(e6a65b4e66902eb759352cd225fe67053e8a766d)</span></li>

 <li>KTp/Models/rooms-model.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Models/rooms-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Widgets/CMakeLists.txt <span style="color: grey">(0dcf7c13ef7013afb94e3685f1925d59bece1833)</span></li>

 <li>KTp/Widgets/join-chat-room-dialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Widgets/join-chat-room-dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Widgets/join-chat-room-dialog.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104534/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>