Review Request: [logviewer] Fix loading logs when selecting contact

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106241/#review18128
-----------------------------------------------------------

Ship it!


Ship it!


logviewer/log-viewer.cpp
<http://git.reviewboard.kde.org/r/106241/#comment14362>

    just delete this. Whoever wrote that was clearly a noob (me).


- David Edmundson


On Aug. 27, 2012, 8:28 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106241/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 8:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> I've noticed today that when you select a contact which has a log for currently selected date, the log is not loaded and you have to select another date and then jump back to the original date to force the log to load. That was because the code was querying for currently selected date before the dates were actually loaded in the date picker and so the picker returned empty QDate. 
> 
> This patch should fix it by waiting for the DatePicker to retrieve the dates from LogManager first and then loading the log to the MessageView.
> 
> 
> Diffs
> -----
> 
>   logviewer/conversation-date-picker.cpp e167853 
>   logviewer/log-viewer.cpp 2494368 
> 
> Diff: http://git.reviewboard.kde.org/r/106241/diff/
> 
> 
> Testing
> -------
> 
> Seems to work for me but I'd appreciate if someone else could confirm it's fixed and there are no side effects (duplicated messages namely)
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120827/a9923013/attachment.html>