Review Request: [logviewer] Fix loading logs when selecting contact

Dan Vratil dan at progdan.cz
Mon Aug 27 20:28:29 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106241/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

I've noticed today that when you select a contact which has a log for currently selected date, the log is not loaded and you have to select another date and then jump back to the original date to force the log to load. That was because the code was querying for currently selected date before the dates were actually loaded in the date picker and so the picker returned empty QDate. 

This patch should fix it by waiting for the DatePicker to retrieve the dates from LogManager first and then loading the log to the MessageView.


Diffs
-----

  logviewer/conversation-date-picker.cpp e167853 
  logviewer/log-viewer.cpp 2494368 

Diff: http://git.reviewboard.kde.org/r/106241/diff/


Testing
-------

Seems to work for me but I'd appreciate if someone else could confirm it's fixed and there are no side effects (duplicated messages namely)


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120827/9ae465f8/attachment.html>


More information about the KDE-Telepathy mailing list