Review Request: Implement Youtube Filter

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105923/#review17096
-----------------------------------------------------------

Ship it!


>Okay, this uses HTML5 to embed the video instead of scraping/parsing json/mucking about with CSS.

There's no scraping, youtube have a whole API.

I feel this decision wasn't really one influenced by what would be the best experience, but rather simply laziness.
Showing the video title would be good.

All data is available here:
https://gdata.youtube.com/feeds/api/videos/YLhYF4tTRAE?v=2&alt=json
then you need to convert with QJson with something like .toMap["entry"].toMap["title"].toMap["t"].toString()

However, it's good enough. Move on to the next plugin.

don't actually ship it yet. We're in a freeze, I hope you're doing all these plugins in a new branch, maybe you can push that to your scratch/clone repo or something.

- David Edmundson


On Aug. 8, 2012, 7:12 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105923/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 7:12 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Okay, this uses HTML5 to embed the video instead of scraping/parsing json/mucking about with CSS.
> It's easier, and this way you can actually play it as well.
> 
> The chat plasmoid appears to gracefully ignore it, which IMHO is better than having a preview of a video that you can't actually play.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ca5ec1e 
>   filters/youtube/CMakeLists.txt PRE-CREATION 
>   filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
>   filters/youtube/youtube-filter.h PRE-CREATION 
>   filters/youtube/youtube-filter.cpp PRE-CREATION 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
> 
> Diff: http://git.reviewboard.kde.org/r/105923/diff/
> 
> 
> Testing
> -------
> 
> Watched http://www.youtube.com/watch?v=FiARsQSlzDc in my chat window.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120808/f464986b/attachment.html>