Review Request: Implement Youtube Filter

Lasath Fernando kde at lasath.org
Wed Aug 8 07:12:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105923/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Okay, this uses HTML5 to embed the video instead of scraping/parsing json/mucking about with CSS.
It's easier, and this way you can actually play it as well.

The chat plasmoid appears to gracefully ignore it, which IMHO is better than having a preview of a video that you can't actually play.


Diffs
-----

  filters/CMakeLists.txt ca5ec1e 
  filters/youtube/CMakeLists.txt PRE-CREATION 
  filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
  filters/youtube/youtube-filter.h PRE-CREATION 
  filters/youtube/youtube-filter.cpp PRE-CREATION 
  tests/message-processor-basic-tests.h 7dc99e4 
  tests/message-processor-basic-tests.cpp 8546605 

Diff: http://git.reviewboard.kde.org/r/105923/diff/


Testing
-------

Watched http://www.youtube.com/watch?v=FiARsQSlzDc in my chat window.


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120808/2721fff0/attachment.html>


More information about the KDE-Telepathy mailing list