Review Request: Allow inviting users to chats and joining MUC group chats

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105814/#review16828
-----------------------------------------------------------



app/telepathy-chat-ui.cpp
<http://git.reviewboard.kde.org/r/105814/#comment13153>

    Shouldn't this be if (textChannel->groupLocalPendingContacts().contains(textChannel->groupSelfContact())) ?
    
    i.e. if the self contact is in "LocalPendingMembers", add it to the "Members". Checking if it is NOT in the LocalPendingMembers doesn't make any sense to me. And checking for isConference() is irrelevant.


- George Kiagiadakis


On Aug. 1, 2012, 1:21 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105814/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 1:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Allow inviting users to chats and joining MUC group chats.
> Launches the normal user selection dialog from common-internals.
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt 2e05cd7 
>   app/chat-window.cpp 84bd6d6 
>   app/invite-contact-dialog.h PRE-CREATION 
>   app/invite-contact-dialog.cpp PRE-CREATION 
>   app/telepathy-chat-ui.cpp f3d6bdf 
> 
> Diff: http://git.reviewboard.kde.org/r/105814/diff/
> 
> 
> Testing
> -------
> 
> Not enough, but I need more friends with the patch in order to try it.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120803/3d70b533/attachment.html>