Review Request: Allow inviting users to chats and joining MUC group chats

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105814/#review16819
-----------------------------------------------------------

Ship it!


I think it should be possible to select multiple contacts, but for now good as it is.


app/chat-window.cpp
<http://git.reviewboard.kde.org/r/105814/#comment13146>

    FIXIT!!!
    
    Since there's no multiple contact selection, this will leak everytime you open this dialog for X contacts you want to invite, which is baaaaad.



app/invite-contact-dialog.cpp
<http://git.reviewboard.kde.org/r/105814/#comment13147>

    No. Because the button is disabled unless you select a contact.


- Martin Klapetek


On Aug. 1, 2012, 1:21 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105814/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 1:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Allow inviting users to chats and joining MUC group chats.
> Launches the normal user selection dialog from common-internals.
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt 2e05cd7 
>   app/chat-window.cpp 84bd6d6 
>   app/invite-contact-dialog.h PRE-CREATION 
>   app/invite-contact-dialog.cpp PRE-CREATION 
>   app/telepathy-chat-ui.cpp f3d6bdf 
> 
> Diff: http://git.reviewboard.kde.org/r/105814/diff/
> 
> 
> Testing
> -------
> 
> Not enough, but I need more friends with the patch in order to try it.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120803/0d1016f5/attachment-0001.html>