Review Request: Add class ContactGridDialog
David Edmundson
kde at davidedmundson.co.uk
Fri Aug 3 08:30:05 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105835/#review16812
-----------------------------------------------------------
KTp/Widgets/contact-grid-dialog.h
<http://git.reviewboard.kde.org/r/105835/#comment13141>
KTP_EXPORT is needed here
- David Edmundson
On Aug. 3, 2012, 8:03 a.m., Daniele Elmo Domenichelli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105835/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 8:03 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Import and fix the dialog used by David and me in KBattleship [1]
>
> I know it's late, but it would be good to have this in 0.5
>
> [1]http://www.sharpley.org.uk/blog/telepathy-tubes-in-kbattleship
>
>
> Diffs
> -----
>
> KTp/Widgets/contact-grid-dialog.h PRE-CREATION
> KTp/Widgets/contact-grid-dialog.cpp PRE-CREATION
> KTp/Widgets/CMakeLists.txt 3486552e40ed3ef7fc1c0c98c54a5184c437fefc
>
> Diff: http://git.reviewboard.kde.org/r/105835/diff/
>
>
> Testing
> -------
>
> Used succesfully in KBattleship
>
>
> Thanks,
>
> Daniele Elmo Domenichelli
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120803/fd5f206d/attachment-0001.html>
More information about the KDE-Telepathy
mailing list