Review Request: Add class ContactGridDialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105835/#review16811
-----------------------------------------------------------

Ship it!


Ship it from me, despite being past feature freeze this isn't going to break anything as it won't break anything and it does make tube-ing a lot easier.


KTp/Widgets/contact-grid-dialog.cpp
<http://git.reviewboard.kde.org/r/105835/#comment13140>

    no reason to explicitly set ContactPtr to 0. 
    but if you do want to do it, do it for account too so it's consistent.
    


- David Edmundson


On Aug. 3, 2012, 8:03 a.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105835/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 8:03 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Import and fix the dialog used by David and me in KBattleship [1]
> 
> I know it's late, but it would be good to have this in 0.5
> 
> [1]http://www.sharpley.org.uk/blog/telepathy-tubes-in-kbattleship
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/contact-grid-dialog.h PRE-CREATION 
>   KTp/Widgets/contact-grid-dialog.cpp PRE-CREATION 
>   KTp/Widgets/CMakeLists.txt 3486552e40ed3ef7fc1c0c98c54a5184c437fefc 
> 
> Diff: http://git.reviewboard.kde.org/r/105835/diff/
> 
> 
> Testing
> -------
> 
> Used succesfully in KBattleship
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120803/f4620164/attachment.html>