Review Request: Chat Plasmoid, small adjustments

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104651/#review12646
-----------------------------------------------------------

Ship it!


Seems good


plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml
<http://git.reviewboard.kde.org/r/104651/#comment9884>

    Trailing whitespace


- Lasath Fernando


On April 18, 2012, 12:59 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104651/
> -----------------------------------------------------------
> 
> (Updated April 18, 2012, 12:59 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> - remove the spacing between contacts. It's not needed.
> - PlasmaWidgets.LineEdit -> PlasmaComponents.TextField.
>   - There was a comment saying that this change would fix the focus problem. FALSE. KWin doesn't put the focus on the chat dialog for some reason (try pressing space, you'll see that the button you clicked is toggled). Good news is that the correct activateWindow call is being made, so that we can sort it out eventually.
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 30efb4d 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml b39208c 
> 
> Diff: http://git.reviewboard.kde.org/r/104651/diff/
> 
> 
> Testing
> -------
> 
> Not much, but works fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120418/80163941/attachment-0001.html>