Review Request: Chat Plasmoid, small adjustments
Aleix Pol Gonzalez
aleixpol at gmail.com
Wed Apr 18 00:59:56 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104651/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
- remove the spacing between contacts. It's not needed.
- PlasmaWidgets.LineEdit -> PlasmaComponents.TextField.
- There was a comment saying that this change would fix the focus problem. FALSE. KWin doesn't put the focus on the chat dialog for some reason (try pressing space, you'll see that the button you clicked is toggled). Good news is that the correct activateWindow call is being made, so that we can sort it out eventually.
Diffs
-----
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 30efb4d
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml b39208c
Diff: http://git.reviewboard.kde.org/r/104651/diff/
Testing
-------
Not much, but works fine.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120418/6824c516/attachment-0001.html>
More information about the KDE-Telepathy
mailing list