Review Request: Review Request : Bug 295840 - You can edit presence message for "offline" in the new status bar

moses alexander moijes12 at gmail.com
Mon Apr 16 19:07:34 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104594/
-----------------------------------------------------------

(Updated April 16, 2012, 7:07 p.m.)


Review request for Telepathy.


Changes
-------

Hi

I have updated the change. I am able to hide the custom presence changer button when it changes to offline/Invisible. But then if someone clicks on the drop down, the the button becomes visible though you still can't edit the presence till you move out of offline or invisible.
 
As always, comments and suggestions will be greatly appreciated.


Description
-------

Hi

This is patch for https://bugs.kde.org/show_bug.cgi?id=295840 . I am able to disallow editing of presence message when the user is Offline or Invisible. 

Comments and suggestions will be appreciated.


Diffs (updated)
-----

  global-presence-chooser.cpp 67e2b34 

Diff: http://git.reviewboard.kde.org/r/104594/diff/


Testing
-------


Thanks,

moses alexander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120416/09a35c49/attachment.html>


More information about the KDE-Telepathy mailing list