Review Request: Review Request : Bug 295840 - You can edit presence message for "offline" in the new status bar

[Rohan Garg]

> On April 14, 2012, 5:09 p.m., David Edmundson wrote:
> > global-presence-chooser.cpp, line 360
> > <http://git.reviewboard.kde.org/r/104594/diff/1/?file=56594#file56594line360>
> >
> >     No, I think this is right.
> >     
> >     !a && !b 
> >     is the same as
> >      ! (a || b)
> >     
> >     therefore 
> >     
> >     (not offline) and (not invisible)
> >     is the same as
> >     not (offline OR invisible)
> >     
> >     
> >     De Morgan wins again \o/

Heh, I tend to read code like one reads English, never thought about applying De Morgan's here. The question now becomes one of readability ( atleast for me, whenever I'll read this in the future, I probably won't remember this and change it inadvertently. Your call )


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104594/#review12435
-----------------------------------------------------------


On April 14, 2012, 3:01 a.m., moses alexander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104594/
> -----------------------------------------------------------
> 
> (Updated April 14, 2012, 3:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Hi
> 
> This is patch for https://bugs.kde.org/show_bug.cgi?id=295840 . I am able to disallow editing of presence message when the user is Offline or Invisible. 
> 
> Comments and suggestions will be appreciated.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 67e2b34 
> 
> Diff: http://git.reviewboard.kde.org/r/104594/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> moses alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120414/68fdcecf/attachment-0001.html>