Review Request: Review Request : When offline, add contact SNI should be hidden

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104555/#review12356
-----------------------------------------------------------


You seem to have created two review requests. Can you discard one of them.

Copied from the other review:
That surely can't be the best way to hide a status notifier.
Check out how else it's used in KDE: http://lxr.kde.org/ident?i=KStatusNotifierItem

Also your patch will hide all contact notifications if any account goes offline, not just ones that are relevant.
Ideally you should be removing the _relevant_ ones from the list m_pendingContacts and then call updateMenus().

Doing this may implicitly solve your hiding the notifier issue too.


- David Edmundson


On April 12, 2012, 5:12 a.m., moses alexander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104555/
> -----------------------------------------------------------
> 
> (Updated April 12, 2012, 5:12 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Hi
> 
> I'm working on https://bugs.kde.org/show_bug.cgi?id=294478 . What I've done is set the SNI to Passive and called setIconByName with an empty QString. But I have a feeling, I'd need to do more. Please provide your suggestions.
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.cpp 37d9996 
> 
> Diff: http://git.reviewboard.kde.org/r/104555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> moses alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120412/4292dd1f/attachment.html>