Review Request: Review Request : When offline, add contact SNI should be hidden

moses alexander moijes12 at gmail.com
Thu Apr 12 05:12:28 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104555/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Hi

I'm working on https://bugs.kde.org/show_bug.cgi?id=294478 . What I've done is set the SNI to Passive and called setIconByName with an empty QString. But I have a feeling, I'd need to do more. Please provide your suggestions.


Diffs
-----

  contact-request-handler.cpp 37d9996 

Diff: http://git.reviewboard.kde.org/r/104555/diff/


Testing
-------


Thanks,

moses alexander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120412/75e742d5/attachment.html>


More information about the KDE-Telepathy mailing list