Review Request: (2/3) Add "Join Chat Room" button to the presence applet

Othmane Moustaouda othmane.moustaouda at gmail.com
Wed Apr 11 19:58:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104534/
-----------------------------------------------------------

(Updated April 11, 2012, 7:58 p.m.)


Review request for Telepathy.


Changes
-------

Use ktelepathyrc config file instead of ktp-contactlistrc because the "join chat room" dialog is not used only by contactlist


Description
-------

Moving join chatroom dialog from contact-list to common-internals to make possible its use also by the presence applet


This addresses bug 293207.
    http://bugs.kde.org/show_bug.cgi?id=293207


Diffs (updated)
-----

  KTp/Models/CMakeLists.txt 7c8d93db5bda62054682ca9bf83a941fc907209b 
  KTp/Models/rooms-model.h PRE-CREATION 
  KTp/Models/rooms-model.cpp PRE-CREATION 
  KTp/Widgets/CMakeLists.txt 3486552e40ed3ef7fc1c0c98c54a5184c437fefc 
  KTp/Widgets/join-chat-room-dialog.h PRE-CREATION 
  KTp/Widgets/join-chat-room-dialog.cpp PRE-CREATION 
  KTp/Widgets/join-chat-room-dialog.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104534/diff/


Testing
-------


Thanks,

Othmane Moustaouda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120411/615d19f7/attachment.html>


More information about the KDE-Telepathy mailing list