Review Request: (2/3) Add "Join Chat Room" button to the presence applet

[Daniele Elmo Domenichelli]

> On None, Othmane Moustaouda wrote:
> > KTp/Widgets/join-chat-room-dialog.cpp, line 63
> > <http://git.reviewboard.kde.org/r/104534/diff/1/?file=56262#file56262line63>
> >
> >     Since this dialog is shared among different widgets, perhaps here it's better using ktelepathyrc config file

+1 for ktelepathyrc


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104534/#review12291
-----------------------------------------------------------


On April 10, 2012, 1:35 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104534/
> -----------------------------------------------------------
> 
> (Updated April 10, 2012, 1:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Moving join chatroom dialog from contact-list to common-internals to make possible its use also by the presence applet
> 
> 
> This addresses bug 293207.
>     http://bugs.kde.org/show_bug.cgi?id=293207
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt 7c8d93db5bda62054682ca9bf83a941fc907209b 
>   KTp/Models/rooms-model.h PRE-CREATION 
>   KTp/Models/rooms-model.cpp PRE-CREATION 
>   KTp/Widgets/CMakeLists.txt 3486552e40ed3ef7fc1c0c98c54a5184c437fefc 
>   KTp/Widgets/join-chat-room-dialog.h PRE-CREATION 
>   KTp/Widgets/join-chat-room-dialog.cpp PRE-CREATION 
>   KTp/Widgets/join-chat-room-dialog.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120410/83f6a93d/attachment.html>