Review Request: Fix "set presence status here" bug

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102736/#review6911
-----------------------------------------------------------



package/contents/ui/EditableText.qml
<http://git.reviewboard.kde.org/r/102736/#comment6123>

    You shouldn't set the label contents back to the lineedit. The lineedit should be the data source and the label should be its visualisation, ie. it should only reflect what's in the lineedit and the lineedit should be only edited by user.


- Martin Klapetek


On Sept. 29, 2011, 12:19 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102736/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 12:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fixes the bug stated in the bug report. I've added a "clickMessage" to the lineedit when text is empty.
> 
> 
> This addresses bug 282210.
>     http://bugs.kde.org/show_bug.cgi?id=282210
> 
> 
> Diffs
> -----
> 
>   package/contents/config/main.xml 6cb185a 
>   package/contents/ui/EditableText.qml 23e86df 
>   package/contents/ui/LauncherPanel.qml 999748a 
>   package/contents/ui/main.qml 6739d27 
> 
> Diff: http://git.reviewboard.kde.org/r/102736/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Nwokeka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110929/693fc0db/attachment-0001.html>