Review Request: Fix "set presence status here" bug
David Edmundson
kde at davidedmundson.co.uk
Thu Sep 29 13:03:32 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102736/#review6908
-----------------------------------------------------------
Ship it!
Great.
Make sure you get rid of the old bad hack too. (I think it was in RightPanel.qml but I'm not sure)
package/contents/ui/EditableText.qml
<http://git.reviewboard.kde.org/r/102736/#comment6120>
I think it might be nicer to have this settable to "set display name" and "set status message" by whoever uses EditableText.
- David Edmundson
On Sept. 29, 2011, 12:19 p.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102736/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2011, 12:19 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Fixes the bug stated in the bug report. I've added a "clickMessage" to the lineedit when text is empty.
>
>
> This addresses bug 282210.
> http://bugs.kde.org/show_bug.cgi?id=282210
>
>
> Diffs
> -----
>
> package/contents/config/main.xml 6cb185a
> package/contents/ui/EditableText.qml 23e86df
> package/contents/ui/LauncherPanel.qml 999748a
> package/contents/ui/main.qml 6739d27
>
> Diff: http://git.reviewboard.kde.org/r/102736/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Francesco Nwokeka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110929/00bc1d7a/attachment.html>
More information about the KDE-Telepathy
mailing list