Review Request: QWidget-based tooltips for contact list

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103297/#review8623
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/103297/#comment7293>

    don't call your variable temp.
    
    In this case you can just have
    
    new TooltipManager(...) on it's own without having a local variable
    



tooltips/contacttooltip.cpp
<http://git.reviewboard.kde.org/r/103297/#comment7288>

    New guy needs to add his name here.
    



tooltips/contacttooltip.cpp
<http://git.reviewboard.kde.org/r/103297/#comment7289>

    Can we replace all this with using KTp::Presence?
    
    I think we can. If not make it so we can.



tooltips/contacttooltip.cpp
<http://git.reviewboard.kde.org/r/103297/#comment7291>

    Get rid of this. 
    
    Use Qt::escape.



tooltips/contacttooltip.cpp
<http://git.reviewboard.kde.org/r/103297/#comment7292>

    Try and avoid made up wordification.


- David Edmundson


On Nov. 30, 2011, 4:17 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103297/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 4:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is the result of Google Code-in student Geoffry Song's work, based on David's code (which was stolen from system settings). The tooltips works perfectly, the code is great quality as well, though as it is rather big diff, I'd like to have more eyes on it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 68dc90c 
>   abstract-contact-delegate.cpp 2bd0f55 
>   main-widget.cpp 7f0adf1 
>   tooltips/contacttooltip.h PRE-CREATION 
>   tooltips/contacttooltip.cpp PRE-CREATION 
>   tooltips/contacttooltip.ui PRE-CREATION 
>   tooltips/ktooltip.h PRE-CREATION 
>   tooltips/ktooltip.cpp PRE-CREATION 
>   tooltips/ktooltipwindow.cpp PRE-CREATION 
>   tooltips/ktooltipwindow_p.h PRE-CREATION 
>   tooltips/tooltipmanager.h PRE-CREATION 
>   tooltips/tooltipmanager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103297/diff/diff
> 
> 
> Testing
> -------
> 
> I've been using it for two days now and all hail to Geoffry, who did really awesome job.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111130/42798ccb/attachment-0001.html>