Review Request: Handle contact requests through KDED module
Martin Klapetek
martin.klapetek at gmail.com
Sat Nov 26 00:29:24 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103233/#review8471
-----------------------------------------------------------
Ship it!
I put it through a hell of a testing and works like a charm. Code is awesome, good job!
- Martin Klapetek
On Nov. 26, 2011, 12:26 a.m., Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103233/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2011, 12:26 a.m.)
>
>
> Review request for Telepathy and Martin Klapetek.
>
>
> Description
> -------
>
> This patch enables the KDED module to handle incoming authorization requests through a KSNI, based on the initial work of Martin. Warning: the code is currently untested as at the time I'm sending diff 1 I am unable to do so due to lack of time - please help by reviewing and testing the code.
>
>
> This addresses bug 285410.
> http://bugs.kde.org/show_bug.cgi?id=285410
>
>
> Diffs
> -----
>
> CMakeLists.txt 335d7f7
> contact-request-handler.h PRE-CREATION
> contact-request-handler.cpp PRE-CREATION
> telepathy-module.h 7215c0b
> telepathy-module.cpp 0c3ea5f
>
> Diff: http://git.reviewboard.kde.org/r/103233/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dario Freddi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111126/e1e96efd/attachment-0001.html>
More information about the KDE-Telepathy
mailing list