Review Request: Refactor ErrorDictionary to be a namespace and carrying Tp constants

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103178/#review8288
-----------------------------------------------------------

Ship it!


Seems ok to me, note that you'll need patches to the relevant applications (kded) - though that's pretty trivial so you don't need reviews for that.

Ideally I'd like Martin to have a quick look as this is his code, but I know he's away this weekend so I'm not sure if he'll get a chance.

- David Edmundson


On Nov. 17, 2011, 11:58 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103178/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 11:58 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Instead of having a singleton and a hash, simply return the string when needed - single apps or library initializers should take care of loading catalogs. Also, no moar magic strings, but constants for your wicked minds.
> 
> 
> Diffs
> -----
> 
>   error-dictionary.h ee92d12 
>   error-dictionary.cpp 5f84b7b 
> 
> Diff: http://git.reviewboard.kde.org/r/103178/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111118/34d55316/attachment.html>