<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103178/">http://git.reviewboard.kde.org/r/103178/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems ok to me, note that you'll need patches to the relevant applications (kded) - though that's pretty trivial so you don't need reviews for that.
Ideally I'd like Martin to have a quick look as this is his code, but I know he's away this weekend so I'm not sure if he'll get a chance.</pre>
<br />
<p>- David</p>
<br />
<p>On November 17th, 2011, 11:58 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2011, 11:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of having a singleton and a hash, simply return the string when needed - single apps or library initializers should take care of loading catalogs. Also, no moar magic strings, but constants for your wicked minds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>error-dictionary.h <span style="color: grey">(ee92d12)</span></li>
<li>error-dictionary.cpp <span style="color: grey">(5f84b7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103178/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>