Review Request: Fix the horrid icon in contact list toolbar
Martin Klapetek
martin.klapetek at gmail.com
Mon Nov 7 19:38:01 UTC 2011
> On Nov. 7, 2011, 7:32 p.m., Daniele Elmo Domenichelli wrote:
> > Looks nice, but I'm a bit worried about what could happen with other icon themes... did you try any other?
> > Perhaps it should be a real icon "view-sort-im-status" or something similar?
Yes, our own icon would be super nice. With other themes - I'm not really sure, but one thing will definitely stay clear to the user - the top icon will be online and the second will be away. And these will be the same as everywhere else (presence drop-down, presence plasmoid etc) so it should get the user some clue. The background icon can change significantly, although it's such a specific icon that I think it would stay mostly similar. That and plus the tooltip should work. At least before we get our own icon.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103063/#review8000
-----------------------------------------------------------
On Nov. 7, 2011, 4:40 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103063/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2011, 4:40 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Sometime ago someone changed the icon for sorting by presence to "user-online". The icon didn't really fit in the toolbar and didn't make too much sense. Since there is no good icon, I've "created" my own by taking the "view-sort-ascending" and painting two small overlays over it. See the screenshot.
>
>
> Diffs
> -----
>
> main-widget.cpp 05cf410
>
> Diff: http://git.reviewboard.kde.org/r/103063/diff/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> New toolbar icon
> http://git.reviewboard.kde.org/r/103063/s/326/
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111107/b049ada9/attachment.html>
More information about the KDE-Telepathy
mailing list