Review Request: Fix the horrid icon in contact list toolbar

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Mon Nov 7 19:32:50 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103063/#review8000
-----------------------------------------------------------


Looks nice, but I'm a bit worried about what could happen with other icon themes... did you try any other?
Perhaps it should be a real icon "view-sort-im-status" or something similar?

- Daniele Elmo Domenichelli


On Nov. 7, 2011, 4:40 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103063/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2011, 4:40 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Sometime ago someone changed the icon for sorting by presence to "user-online". The icon didn't really fit in the toolbar and didn't make too much sense. Since there is no good icon, I've "created" my own by taking the "view-sort-ascending" and painting two small overlays over it. See the screenshot.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 05cf410 
> 
> Diff: http://git.reviewboard.kde.org/r/103063/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> New toolbar icon
>   http://git.reviewboard.kde.org/r/103063/s/326/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111107/62361e4f/attachment.html>


More information about the KDE-Telepathy mailing list