Review Request: Add a lineedit to change the "Resource" on gabble accounts.

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Thu May 12 14:41:04 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101319/#review3278
-----------------------------------------------------------


IIRC the resource parameter should be handled together with the priority parameter (that is missing as well) like kopete does. (Also kopete has an useful feature "when absent, adjust priority to", but I believe that it is not a xmpp feature, but something implemented by kopete checking the user's activity.)
Messages are sent by the xmpp server to the resource with the higher priority and I also believe that's the only use for the resource parameter. (I just found [1], so I may be right)

Therefore I'm not sure if it makes sense to allow to set just the resource parameter alone.

[1]http://wiki.xmpp.org/web/Jabber_Resources

- Daniele Elmo


On May 9, 2011, 3:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101319/
> -----------------------------------------------------------
> 
> (Updated May 9, 2011, 3:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add a lineedit to change the "Resource" on gabble accounts.
> 
> 
> Diffs
> -----
> 
>   gabble/server-settings-widget.cpp 7bb9ee06faa76c78e976b47172443125569acb8e 
>   gabble/server-settings-widget.ui 711355301f18f32a0f185cfd63cea8670292242d 
> 
> Diff: http://git.reviewboard.kde.org/r/101319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110512/22307bfe/attachment.htm 


More information about the KDE-Telepathy mailing list