Review Request: Implementation of bug 269052 - Need a method to search within a chat window

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100948/#review2193
-----------------------------------------------------------

Ship it!


Looks all good. but sort out the license at the top of the file before you ship it. It's very boring, but it is important.


lib/chat-search-bar.cpp
<http://git.reviewboard.kde.org/r/100948/#comment1827>

    License!



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/100948/#comment1826>

    I can't think of a syntax people would need that, acting differently on flag changes to text changes.


- David


On March 26, 2011, 1:29 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100948/
> -----------------------------------------------------------
> 
> (Updated March 26, 2011, 1:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Implementation of "search" within the chat window.
> The search widget is called via keyboard shortcut ( standard "ctrl+f ") and can also be modified by the user from the chat settings.
> 
> 
> This addresses bug 269052.
>     http://bugs.kde.org/show_bug.cgi?id=269052
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h cde19e4 
>   app/chat-window.cpp b3407db 
>   lib/CMakeLists.txt 1639cfd 
>   lib/chat-widget.h dfdef64 
>   lib/chat-widget.cpp 5ddf3dd 
>   lib/chat-widget.ui 2dce82f 
> 
> Diff: http://git.reviewboard.kde.org/r/100948/diff
> 
> 
> Testing
> -------
> 
> wrote in a chat and looked for random text. Please try the patch and tell me if some functionality is missing
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110326/7a80760f/attachment.htm