Review Request: Implementation of bug 269052 - Need a method to search within a chat window

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100948/
-----------------------------------------------------------

(Updated March 26, 2011, 1:29 p.m.)


Review request for Telepathy.


Changes
-------

Changed the things David pointed out. 
Eliminated the "highligh all occurences" when searching text because it didn't allow me to change words with the "next" and "previous" buttons. Now this works correctly


Summary
-------

Implementation of "search" within the chat window.
The search widget is called via keyboard shortcut ( standard "ctrl+f ") and can also be modified by the user from the chat settings.


This addresses bug 269052.
    http://bugs.kde.org/show_bug.cgi?id=269052


Diffs (updated)
-----

  app/chat-window.h cde19e4 
  app/chat-window.cpp b3407db 
  lib/CMakeLists.txt 1639cfd 
  lib/chat-widget.h dfdef64 
  lib/chat-widget.cpp 5ddf3dd 
  lib/chat-widget.ui 2dce82f 

Diff: http://git.reviewboard.kde.org/r/100948/diff


Testing
-------

wrote in a chat and looked for random text. Please try the patch and tell me if some functionality is missing


Thanks,

Francesco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110326/a811cfa8/attachment-0001.htm