Review Request: Implement unread messages in the lib and show the status in the app - v2

David Edmundson kde at davidedmundson.co.uk
Wed Mar 9 19:36:31 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100820/#review1864
-----------------------------------------------------------



app/telepathychatui.cpp
<http://git.reviewboard.kde.org/r/100820/#comment1524>

    This whole section with the m_channelWidgetMap should be removed. 
    
    Woki has done a (IMHO) better implementation without the separate map.


- David


On March 8, 2011, 2:18 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100820/
> -----------------------------------------------------------
> 
> (Updated March 8, 2011, 2:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Give an indication of the status of a chat (has unread messages/user is typing etc) via the colour of the text on the tab widget. 
> 
> A continuation of: https://git.reviewboard.kde.org/r/100594/
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt f626914734b29aabcab32c10bbe50894848d7e0d 
>   app/chattab.h PRE-CREATION 
>   app/chattab.cpp PRE-CREATION 
>   app/chatwindow.h 663a54a15b83ac1eba17700df4f2bc0f140000fd 
>   app/chatwindow.cpp fed4381f7a5a5d27587a5f5ba2e82d685a30173e 
>   app/telepathychatui.h 1cfe76ccbc5cb2266c61330c65b1cd2baf760d55 
>   app/telepathychatui.cpp 4415c82d6fdeca0194fc7a9e2509a010dda9fc5a 
>   lib/chatwidget.h dff8a1ea92fbab8dda5d1645b4782973d294616e 
>   lib/chatwidget.cpp 2d57f49b423011d8430c74d73fe76315b5b0a453 
> 
> Diff: http://git.reviewboard.kde.org/r/100820/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110309/b7e00ee3/attachment-0001.htm 


More information about the KDE-Telepathy mailing list