<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100820/">http://git.reviewboard.kde.org/r/100820/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100820/diff/1/?file=10763#file10763line75" style="color: black; font-weight: bold; text-decoration: underline;">app/telepathychatui.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TelepathyChatUi::handleChannels(const Tp::MethodInvocationContextPtr<> & context,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="n">ChannelWidgetPair</span> <span class="n">pair</span><span class="p">,</span> <span class="n">m_channelWidgetMap</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This whole section with the m_channelWidgetMap should be removed.
Woki has done a (IMHO) better implementation without the separate map.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On March 8th, 2011, 2:18 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 8, 2011, 2:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Give an indication of the status of a chat (has unread messages/user is typing etc) via the colour of the text on the tab widget.
A continuation of: https://git.reviewboard.kde.org/r/100594/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/CMakeLists.txt <span style="color: grey">(f626914734b29aabcab32c10bbe50894848d7e0d)</span></li>
<li>app/chattab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/chattab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/chatwindow.h <span style="color: grey">(663a54a15b83ac1eba17700df4f2bc0f140000fd)</span></li>
<li>app/chatwindow.cpp <span style="color: grey">(fed4381f7a5a5d27587a5f5ba2e82d685a30173e)</span></li>
<li>app/telepathychatui.h <span style="color: grey">(1cfe76ccbc5cb2266c61330c65b1cd2baf760d55)</span></li>
<li>app/telepathychatui.cpp <span style="color: grey">(4415c82d6fdeca0194fc7a9e2509a010dda9fc5a)</span></li>
<li>lib/chatwidget.h <span style="color: grey">(dff8a1ea92fbab8dda5d1645b4782973d294616e)</span></li>
<li>lib/chatwidget.cpp <span style="color: grey">(2d57f49b423011d8430c74d73fe76315b5b0a453)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100820/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>