Review Request: Make telepathy-kde compile with TelepathyQt4 0.5

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100808/#review1812
-----------------------------------------------------------


The changes to the jobs look fine to me, assuming they compile and work. The changes to the core stuff (replacing Tp::WeakPtr with QWeakPointer) are *not* OK, but there is no simple solution because of the refcounting semantics used etc.... which will require quite a lot of refactoring of the files under core/ in this repo. I'll take a look at the core stuff once I'm back to hacking again (probably towards the end of this month). In the mean time, I'm happy for this to go in the main repo as a branch, but not as master since it will behave brokenly, and possibly even cause random crashes until the shared-pointer stuff is properly sorted out, despite compiling OK now.


src/core/people-manager.cpp
<http://git.reviewboard.kde.org/r/100808/#comment1494>

    


- George


On March 6, 2011, 4:41 p.m., Arno Rehn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100808/
> -----------------------------------------------------------
> 
> (Updated March 6, 2011, 4:41 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch makes telepathy-kde compile with Telepathy-Qt4 0.5. I've only fixed the actual compilation errors and a deprecated signal. There are probably more deprecated/removed signals in the code that haven't been addressed yet. This is my first contact with Telepathy, so there are probably some issues in my code as well.
> I'd suggest pushing this to a seperate feature branch until it's considered mature enough.
> 
> 
> Diffs
> -----
> 
>   src/core/people-manager.cpp 7d70aafa3e1882c742d2928545b9bf54a0c3c749 
>   src/jobs/offer-file-transfer-job.cpp 002a69185fa7da6fbf94faf6b4b0d336e1fec730 
>   src/jobs/telepathy-account-proxy.h d0664006b9dd75b992883723c9140d156fd674eb 
>   src/jobs/telepathy-account-proxy.cpp 23736acdae3a9c4afff47bfefddccacce34369df 
>   src/jobs/telepathy-bridge.h 7bc28c2be55be8af0628dd6a61927c0504f8c4a0 
>   src/jobs/telepathy-bridge.cpp 443feb764051e5488085ddcbed2b8b4f657a5754 
>   src/jobs/telepathy-bridge_p.h 483d08c36b368813d04965d4f8e8c0925da3b0e8 
> 
> Diff: http://git.reviewboard.kde.org/r/100808/diff
> 
> 
> Testing
> -------
> 
> I've only confirmed that it compiles yet.
> 
> 
> Thanks,
> 
> Arno
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110306/c9d31275/attachment.htm