<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100808/">http://git.reviewboard.kde.org/r/100808/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changes to the jobs look fine to me, assuming they compile and work. The changes to the core stuff (replacing Tp::WeakPtr with QWeakPointer) are *not* OK, but there is no simple solution because of the refcounting semantics used etc.... which will require quite a lot of refactoring of the files under core/ in this repo. I'll take a look at the core stuff once I'm back to hacking again (probably towards the end of this month). In the mean time, I'm happy for this to go in the main repo as a branch, but not as master since it will behave brokenly, and possibly even cause random crashes until the shared-pointer stuff is properly sorted out, despite compiling OK now.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100808/diff/1/?file=10620#file10620line55" style="color: black; font-weight: bold; text-decoration: underline;">src/core/people-manager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Tp</span></span><span class="o"><span class="hl">::</span></span><span class="n">WeakP<span class="hl">t</span>r</span><span class="o"><</span><span class="n">EveryonePersonSet</span><span class="o">></span> <span class="n">everyonePersonSet</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Q</span>WeakP<span class="hl">ointe</span>r</span><span class="o"><</span><span class="n">EveryonePersonSet</span><span class="o">></span> <span class="n">everyonePersonSet</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"></pre>
</div>
<br />
<p>- George</p>
<br />
<p>On March 6th, 2011, 4:41 p.m., Arno Rehn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Arno Rehn.</div>
<p style="color: grey;"><i>Updated March 6, 2011, 4:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes telepathy-kde compile with Telepathy-Qt4 0.5. I've only fixed the actual compilation errors and a deprecated signal. There are probably more deprecated/removed signals in the code that haven't been addressed yet. This is my first contact with Telepathy, so there are probably some issues in my code as well.
I'd suggest pushing this to a seperate feature branch until it's considered mature enough.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've only confirmed that it compiles yet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/people-manager.cpp <span style="color: grey">(7d70aafa3e1882c742d2928545b9bf54a0c3c749)</span></li>
<li>src/jobs/offer-file-transfer-job.cpp <span style="color: grey">(002a69185fa7da6fbf94faf6b4b0d336e1fec730)</span></li>
<li>src/jobs/telepathy-account-proxy.h <span style="color: grey">(d0664006b9dd75b992883723c9140d156fd674eb)</span></li>
<li>src/jobs/telepathy-account-proxy.cpp <span style="color: grey">(23736acdae3a9c4afff47bfefddccacce34369df)</span></li>
<li>src/jobs/telepathy-bridge.h <span style="color: grey">(7bc28c2be55be8af0628dd6a61927c0504f8c4a0)</span></li>
<li>src/jobs/telepathy-bridge.cpp <span style="color: grey">(443feb764051e5488085ddcbed2b8b4f657a5754)</span></li>
<li>src/jobs/telepathy-bridge_p.h <span style="color: grey">(483d08c36b368813d04965d4f8e8c0925da3b0e8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100808/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>