Review Request: Licensing fixes in the text-ui

[Dominik Schmidt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101555/#review4109
-----------------------------------------------------------

Ship it!


Awesome, thanks for doing the dirty work.

(Yes, you're right, I don't have a preference)

- Dominik


On June 9, 2011, 8:15 a.m., George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101555/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 8:15 a.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Dominik Schmidt.
> 
> 
> Summary
> -------
> 
> This patch adds a license header to some files that were missing one and also changes the license of certain files from GPLv3+ to GPLv2+. I had asked about the GPLv3 usage in the past and the impression I got was that you guys don't really have a preference over a specific version of the GPL, but you used GPLv3 just because kdevelop adds it automatically for new files. If this is really the case, I would prefer changing to GPLv2 now so that we have a single license for all the text-ui components and make it compatible with the KDE licensing policy [1]. If you *do* have a preference, then we can keep GPLv3, but this effectively makes all of the text-ui GPLv3+, so you must be careful never to add GPLv2-only code or to link to some GPLv2-only library, as they are incompatible.
> 
> PS: I will need a "ship it" from both David and Dominik here.
> 
> [1]. http://techbase.kde.org/Policies/Licensing_Policy
> 
> 
> Diffs
> -----
> 
>   adiumxtra-protocol-handler/adiumxtra-protocol-handler.h b6faf96b9e9430a1305302252c5895d8abc5c68e 
>   adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp 29c7efa6b8cb0cd66c3d3f750647dcda6fb206e9 
>   adiumxtra-protocol-handler/bundle-installer.h 17ecf5b03525d40d699eb7b8c6d8b8978a82cbc6 
>   adiumxtra-protocol-handler/bundle-installer.cpp 29541c166d3dcf9554f2c7b040e8a91dec50ce2b 
>   adiumxtra-protocol-handler/chat-style-installer.h 4408a8d01760542c0f2ac2f73ab69951145e0daa 
>   adiumxtra-protocol-handler/chat-style-installer.cpp 4a8ef01127b04de5d52f74c80ac4cd719614481a 
>   adiumxtra-protocol-handler/emoticon-set-installer.h 2add6ac0cd73bf5cd5608fc59016f8c148322706 
>   adiumxtra-protocol-handler/emoticon-set-installer.cpp 47d593ecc5e4de70529deab42c59301b1d502a2e 
>   adiumxtra-protocol-handler/main.cpp d07086397ba0a572698642268d795073ce59a903 
>   app/chat-window.h 010eea2e0dd6028214970691862365eeb55d399d 
>   app/chat-window.cpp 59c2e9ca578085a23f1676c3201cdd6e30ae1b9e 
>   app/telepathy-chat-ui.h 3d2001588a073215fe90d3816d5b9ab8c3cd2144 
>   app/telepathy-chat-ui.cpp 1d013a497fd0554e17c92bb543e68d9e02fc61fb 
> 
> Diff: http://git.reviewboard.kde.org/r/101555/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110623/963017b7/attachment.htm