<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101555/">http://git.reviewboard.kde.org/r/101555/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Awesome, thanks for doing the dirty work.
(Yes, you're right, I don't have a preference)</pre>
<br />
<p>- Dominik</p>
<br />
<p>On June 9th, 2011, 8:15 a.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Dominik Schmidt.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated June 9, 2011, 8:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a license header to some files that were missing one and also changes the license of certain files from GPLv3+ to GPLv2+. I had asked about the GPLv3 usage in the past and the impression I got was that you guys don't really have a preference over a specific version of the GPL, but you used GPLv3 just because kdevelop adds it automatically for new files. If this is really the case, I would prefer changing to GPLv2 now so that we have a single license for all the text-ui components and make it compatible with the KDE licensing policy [1]. If you *do* have a preference, then we can keep GPLv3, but this effectively makes all of the text-ui GPLv3+, so you must be careful never to add GPLv2-only code or to link to some GPLv2-only library, as they are incompatible.
PS: I will need a "ship it" from both David and Dominik here.
[1]. http://techbase.kde.org/Policies/Licensing_Policy</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>adiumxtra-protocol-handler/adiumxtra-protocol-handler.h <span style="color: grey">(b6faf96b9e9430a1305302252c5895d8abc5c68e)</span></li>
<li>adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp <span style="color: grey">(29c7efa6b8cb0cd66c3d3f750647dcda6fb206e9)</span></li>
<li>adiumxtra-protocol-handler/bundle-installer.h <span style="color: grey">(17ecf5b03525d40d699eb7b8c6d8b8978a82cbc6)</span></li>
<li>adiumxtra-protocol-handler/bundle-installer.cpp <span style="color: grey">(29541c166d3dcf9554f2c7b040e8a91dec50ce2b)</span></li>
<li>adiumxtra-protocol-handler/chat-style-installer.h <span style="color: grey">(4408a8d01760542c0f2ac2f73ab69951145e0daa)</span></li>
<li>adiumxtra-protocol-handler/chat-style-installer.cpp <span style="color: grey">(4a8ef01127b04de5d52f74c80ac4cd719614481a)</span></li>
<li>adiumxtra-protocol-handler/emoticon-set-installer.h <span style="color: grey">(2add6ac0cd73bf5cd5608fc59016f8c148322706)</span></li>
<li>adiumxtra-protocol-handler/emoticon-set-installer.cpp <span style="color: grey">(47d593ecc5e4de70529deab42c59301b1d502a2e)</span></li>
<li>adiumxtra-protocol-handler/main.cpp <span style="color: grey">(d07086397ba0a572698642268d795073ce59a903)</span></li>
<li>app/chat-window.h <span style="color: grey">(010eea2e0dd6028214970691862365eeb55d399d)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(59c2e9ca578085a23f1676c3201cdd6e30ae1b9e)</span></li>
<li>app/telepathy-chat-ui.h <span style="color: grey">(3d2001588a073215fe90d3816d5b9ab8c3cd2144)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(1d013a497fd0554e17c92bb543e68d9e02fc61fb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101555/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>