Review Request: Get Person/Contact/PersonSetModel up to date and fully functional with basic read-only properties

[George Goldberg]

> On June 16, 2011, 10:08 a.m., David Edmundson wrote:
> > src/core/contact.h, line 113
> > <http://git.reviewboard.kde.org/r/101636/diff/1/?file=24533#file24533line113>
> >
> >     Can we cast to the the correct Tp enum?
> >     
> >     Arbitrary ints are generally sucky.

Yes, we can :)

Can't remember why uint is used there but I think it was some legacy reason, perhaps related to QML. I'll change it and update the patch.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101636/#review3923
-----------------------------------------------------------


On June 15, 2011, 8:49 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101636/
> -----------------------------------------------------------
> 
> (Updated June 15, 2011, 8:49 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch massively tidies up Contact/Person/PersonSetModel classes, which are the basic classes needed for the Nepomuk enabled contact list port to get underway. All the basic readonly properties are now fully functional, with all short-term FIXME's dealt with.
> 
> 
> Diffs
> -----
> 
>   src/core/contact.h 026a7361a35556a261a1ad10910bf846b024bd64 
>   src/core/contact.cpp c91058a261fe4f79dd505d97f901401c09ba53b4 
>   src/core/person.h eb017da98d8a01a8555ef3568f095bf2cfe74109 
>   src/core/person.cpp 4269789b0d45838024901907d728b058ae17e8de 
>   src/ui/person-set-model.h 95416fff218ad568149ad453f692a9fcdfa635b2 
>   src/ui/person-set-model.cpp 7a5849af208d7596171ebb8c95adcf488135d73d 
> 
> Diff: http://git.reviewboard.kde.org/r/101636/diff
> 
> 
> Testing
> -------
> 
> Unit tests still pass.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110617/41f66160/attachment.htm