Review Request: Use presence state icon instead of kde-telepathy icon in presence-applet

David Edmundson kde at davidedmundson.co.uk
Tue Jun 14 17:23:55 CEST 2011



> On June 14, 2011, 7:54 a.m., Francesco Nwokeka wrote:
> > I fixed your patch. May I have your mail for the commit please?
> 
> Jan Gerrit Marker wrote:
>     Of course, here it is:
>     jangerrit at weiler-marker.com
> 
> Francesco Nwokeka wrote:
>     committed. Please close review.

Nwoki in future if you use 
REVIEW: 101603
in the commit message it will close the review for you (regardless of who opened it)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101603/#review3875
-----------------------------------------------------------


On June 13, 2011, 12:45 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101603/
> -----------------------------------------------------------
> 
> (Updated June 13, 2011, 12:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Currently the presence-applet has the kde-telepathy icon as popup icon. This patch uses the icon of the global presence state as popup icon.
> 
> 
> Diffs
> -----
> 
>   package/contents/ui/main.qml 1bd29dcfb29874b97e163aa67b98d1319c8621df 
> 
> Diff: http://git.reviewboard.kde.org/r/101603/diff
> 
> 
> Testing
> -------
> 
> Works here. When plasma is started the icon is still the kde-telepathy icon.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110614/ef7aacc6/attachment-0001.htm 


More information about the KDE-Telepathy mailing list