Review Request: Improve link highlighting in AdiumThemeView

Commit Hook null at kde.org
Wed Jul 20 22:33:05 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102024/#review4914
-----------------------------------------------------------


This review has been submitted with commit 0d7162e4cced7eacfc7ac94c82c3e5c3a569356f by Alex Richardson to branch master.

- Commit


On July 20, 2011, 8:15 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102024/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 8:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Also highlight links that don't start with "<protocol>://", but also links that start with "www.".
> Also update regular expression to use not whitespace instead of listing all whitespace characters explicitly
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.cpp 9de0d65 
> 
> Diff: http://git.reviewboard.kde.org/r/102024/diff
> 
> 
> Testing
> -------
> 
> Previously "www.kde.org" was not highlighted and clickable, now it is.
> Any other links starting with a protocol still work as before.
> 
> 
> Thanks,
> 
> Alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110720/6964d534/attachment.htm 


More information about the KDE-Telepathy mailing list