Review Request: Fix previous "Detach Tabs" patch

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101899/#review4768
-----------------------------------------------------------


This review has been submitted with commit cdede19e22f97ce0623c7116c36b904fc28a55d6 by Paolo Capriotti to branch master.

- Commit


On July 9, 2011, 12:28 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101899/
> -----------------------------------------------------------
> 
> (Updated July 9, 2011, 12:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch consists in a tidy-up of the previous patch and the elimination of unused methods, logic and the tidy up of some methods and functionality.
> Added comments to code as well.
> The aim of this patch is to keep the code as tidy and simple as possible.
> 
> 
> Diffs
> -----
> 
>   app/chat-tab.h 408bb91 
>   app/chat-tab.cpp 018868e 
>   app/chat-window.h a46e41b 
>   app/chat-window.cpp 28905fa 
>   app/telepathy-chat-ui.h ad6809f 
>   app/telepathy-chat-ui.cpp 71ac4ee 
> 
> Diff: http://git.reviewboard.kde.org/r/101899/diff
> 
> 
> Testing
> -------
> 
> Created more than one chat forcing the creation in one window, detached, closed, reopened and all went well.
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110717/65584ccf/attachment.htm