<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101899/">http://git.reviewboard.kde.org/r/101899/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit cdede19e22f97ce0623c7116c36b904fc28a55d6 by Paolo Capriotti to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 9th, 2011, 12:28 p.m., Francesco Nwokeka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Francesco Nwokeka.</div>
<p style="color: grey;"><i>Updated July 9, 2011, 12:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch consists in a tidy-up of the previous patch and the elimination of unused methods, logic and the tidy up of some methods and functionality.
Added comments to code as well.
The aim of this patch is to keep the code as tidy and simple as possible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created more than one chat forcing the creation in one window, detached, closed, reopened and all went well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-tab.h <span style="color: grey">(408bb91)</span></li>
<li>app/chat-tab.cpp <span style="color: grey">(018868e)</span></li>
<li>app/chat-window.h <span style="color: grey">(a46e41b)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(28905fa)</span></li>
<li>app/telepathy-chat-ui.h <span style="color: grey">(ad6809f)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(71ac4ee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101899/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>