Review Request: port telepathy-call-ui to telepathy-qt4-0.5 and recent qt-gstreamer

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100429/#review1060
-----------------------------------------------------------


It's ok in overall, I won't really go deep into reviewing every detail as I expect the code to change anyway...


src/main.cpp
<http://git.reviewboard.kde.org/r/100429/#comment850>

    Ugh, why the Connection features ended up in ContactFactory?



test-contactlist/libkcallprivate/accountitem.cpp
<http://git.reviewboard.kde.org/r/100429/#comment851>

    This makes no sense at all...
    
    The purpose of this if + switch statements was to handle the case of SIP accounts where the CM does not report presence, so it tries to simulate a fake presence depending on the state of the connection.
    
    With this patch, it really does nothing at all.



test-contactlist/libkcallprivate/pendingcontacts.cpp
<http://git.reviewboard.kde.org/r/100429/#comment852>

    Remove instead of commenting out



test-contactlist/systrayicon.cpp
<http://git.reviewboard.kde.org/r/100429/#comment849>

    I just asked #telepathy about those unnamed* variants and they told me to pretend they don't exist and not to use them.


- George


On Jan. 25, 2011, 4:37 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100429/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2011, 4:37 p.m.)
> 
> 
> Review request for Telepathy, George Kiagiadakis and David Edmundson.
> 
> 
> Summary
> -------
> 
> port to telepathy-qt4-0.5
> port to recent qt-gstreamer
> 
> it's not meant to be finished, it compiles, runs but doesn't work for me
> 
> use one of these qt-gstreamer sources:
> http://gstreamer.freedesktop.org/src/qt-gstreamer/
> git://anongit.freedesktop.org/gstreamer/qt-gstreamer
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 285ebb75a51fa931df40654169eada8cef886e19 
>   libtelepathy-kde-call/callchannelhandler.cpp 8eb00bebb5dc90ef687894d32b85e63fba8c9a76 
>   libtelepathy-kde-call/configuration_test.cpp 69d2e7f31ad96b6e1a35fc947fa8d67237f39dfe 
>   libtelepathy-kde-call/deviceelementfactory.cpp dbcd7a1a543cf1800ba1763e9e5770f9a120f3f8 
>   libtelepathy-kde-call/phononintegration.cpp 884904afa15688787304ddf8f2c8f4b90375b5bf 
>   src/callhandler.h 8d551ebb15488cce7755243f544b8c53afccd4be 
>   src/callhandler.cpp 475856e1fbe07430c3eebd5bfa91b24f27458571 
>   src/dtmfhandler.cpp 24739b63270946654897d896c6ee43a6b030601f 
>   src/main.cpp a3e590c30d53468d2281c8494b50c7bf3b9d539f 
>   test-contactlist/libkcallprivate/abstractclientapprover.h a89ec766232a509ef6a72c0c49ae47fd2003f367 
>   test-contactlist/libkcallprivate/abstractclientapprover.cpp 3fa8ce5cad0b77f78dba5de69d417294cccb63f9 
>   test-contactlist/libkcallprivate/accountitem.h cd40a935f74b62a71bee97927cc83810efa6f794 
>   test-contactlist/libkcallprivate/accountitem.cpp ce1d4aa2c33a29edd6970d0209ec560097bd4dd8 
>   test-contactlist/libkcallprivate/accountmanager.h 40cd91936d1e4bd73de201488cb1c24c3389486f 
>   test-contactlist/libkcallprivate/accountmanager.cpp 222f6bcc327343a001529035f081bec4d287c1d7 
>   test-contactlist/libkcallprivate/contactitem.cpp 3dbc1f2866c4af2d29065bda4b9ceab3da008aa4 
>   test-contactlist/libkcallprivate/pendingcontacts.cpp 4cabbad40c3528174683ee26a60afe5299750d7e 
>   test-contactlist/systrayicon.cpp e41e7cf0ad6b196dc455db4cd5b1d0de8f76be44 
> 
> Diff: http://git.reviewboard.kde.org/r/100429/diff
> 
> 
> Testing
> -------
> 
> none, doesn't work for me atm :/
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110125/dc51d34a/attachment.htm