<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100429/">http://git.reviewboard.kde.org/r/100429/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's ok in overall, I won't really go deep into reviewing every detail as I expect the code to change anyway...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100429/diff/1/?file=7367#file7367line56" style="color: black; font-weight: bold; text-decoration: underline;">src/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main(int argc, char **argv)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Tp</span><span class="o">::</span><span class="n">Features</span><span class="p">()</span> <span class="o"><<</span> <span class="n">Tp</span><span class="o">::</span><span class="n">Connection</span><span class="o">::</span><span class="n">FeatureCore</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Tp</span><span class="o">::</span><span class="n">Features</span><span class="p">()</span> <span class="o"><<</span> <span class="n">Tp</span><span class="o">::</span><span class="n">Connection</span><span class="o">::</span><span class="n">FeatureCore</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ugh, why the Connection features ended up in ContactFactory?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100429/diff/1/?file=7371#file7371line63" style="color: black; font-weight: bold; text-decoration: underline;">test-contactlist/libkcallprivate/accountitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QVariant AccountItem::data(int role) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">presence</span><span class="p">.</span><span class="n">type</span> <span class="o">=</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ConnectionPresenceTypeAvailable</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_account</span><span class="o">-></span><span class="n">currentPresence</span><span class="p">().</span><span class="n">available</span><span class="p">(</span><span class="s">"available"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes no sense at all...
The purpose of this if + switch statements was to handle the case of SIP accounts where the CM does not report presence, so it tries to simulate a fake presence depending on the state of the connection.
With this patch, it really does nothing at all.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100429/diff/1/?file=7375#file7375line52" style="color: black; font-weight: bold; text-decoration: underline;">test-contactlist/libkcallprivate/pendingcontacts.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PendingContacts::onConnectionReady(Tp::PendingOperation *op)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Tp</span><span class="o">::</span><span class="n">Connection</span> <span class="o">*</span><span class="n">connection</span> <span class="o">=</span> <span class="n">qobject_cast</span><span class="o"><</span><span class="n">Tp</span><span class="o">::</span><span class="n">Connection</span><span class="o">*></span><span class="p">(</span><span class="n">pr</span><span class="o">-></span><span class="n">object</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">// </span> Tp::Connection *connection = qobject_cast<Tp::Connection*>(pr->object());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove instead of commenting out</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100429/diff/1/?file=7376#file7376line35" style="color: black; font-weight: bold; text-decoration: underline;">test-contactlist/systrayicon.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o"><<</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ChannelClassSpec</span><span class="o">::</span><span class="n">unnamedStreamedMediaVideoCall</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just asked #telepathy about those unnamed* variants and they told me to pretend they don't exist and not to use them.</pre>
</div>
<br />
<p>- George</p>
<br />
<p>On January 25th, 2011, 4:37 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, George Kiagiadakis and David Edmundson.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2011, 4:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">port to telepathy-qt4-0.5
port to recent qt-gstreamer
it's not meant to be finished, it compiles, runs but doesn't work for me
use one of these qt-gstreamer sources:
http://gstreamer.freedesktop.org/src/qt-gstreamer/
git://anongit.freedesktop.org/gstreamer/qt-gstreamer
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">none, doesn't work for me atm :/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(285ebb75a51fa931df40654169eada8cef886e19)</span></li>
<li>libtelepathy-kde-call/callchannelhandler.cpp <span style="color: grey">(8eb00bebb5dc90ef687894d32b85e63fba8c9a76)</span></li>
<li>libtelepathy-kde-call/configuration_test.cpp <span style="color: grey">(69d2e7f31ad96b6e1a35fc947fa8d67237f39dfe)</span></li>
<li>libtelepathy-kde-call/deviceelementfactory.cpp <span style="color: grey">(dbcd7a1a543cf1800ba1763e9e5770f9a120f3f8)</span></li>
<li>libtelepathy-kde-call/phononintegration.cpp <span style="color: grey">(884904afa15688787304ddf8f2c8f4b90375b5bf)</span></li>
<li>src/callhandler.h <span style="color: grey">(8d551ebb15488cce7755243f544b8c53afccd4be)</span></li>
<li>src/callhandler.cpp <span style="color: grey">(475856e1fbe07430c3eebd5bfa91b24f27458571)</span></li>
<li>src/dtmfhandler.cpp <span style="color: grey">(24739b63270946654897d896c6ee43a6b030601f)</span></li>
<li>src/main.cpp <span style="color: grey">(a3e590c30d53468d2281c8494b50c7bf3b9d539f)</span></li>
<li>test-contactlist/libkcallprivate/abstractclientapprover.h <span style="color: grey">(a89ec766232a509ef6a72c0c49ae47fd2003f367)</span></li>
<li>test-contactlist/libkcallprivate/abstractclientapprover.cpp <span style="color: grey">(3fa8ce5cad0b77f78dba5de69d417294cccb63f9)</span></li>
<li>test-contactlist/libkcallprivate/accountitem.h <span style="color: grey">(cd40a935f74b62a71bee97927cc83810efa6f794)</span></li>
<li>test-contactlist/libkcallprivate/accountitem.cpp <span style="color: grey">(ce1d4aa2c33a29edd6970d0209ec560097bd4dd8)</span></li>
<li>test-contactlist/libkcallprivate/accountmanager.h <span style="color: grey">(40cd91936d1e4bd73de201488cb1c24c3389486f)</span></li>
<li>test-contactlist/libkcallprivate/accountmanager.cpp <span style="color: grey">(222f6bcc327343a001529035f081bec4d287c1d7)</span></li>
<li>test-contactlist/libkcallprivate/contactitem.cpp <span style="color: grey">(3dbc1f2866c4af2d29065bda4b9ceab3da008aa4)</span></li>
<li>test-contactlist/libkcallprivate/pendingcontacts.cpp <span style="color: grey">(4cabbad40c3528174683ee26a60afe5299750d7e)</span></li>
<li>test-contactlist/systrayicon.cpp <span style="color: grey">(e41e7cf0ad6b196dc455db4cd5b1d0de8f76be44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100429/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>