Review Request: Make AccountListModel comply to ModelTest

[Thomas Richard]

> On Jan. 22, 2011, 2:04 a.m., David Edmundson wrote:
> > src/accounts-list-model.cpp, line 232
> > <http://git.reviewboard.kde.org/r/100431/diff/1/?file=7388#file7388line232>
> >
> >     In future, if possible link to a specific bug report.
> >     
> >     That way someone viewing this code in 2 years time will know what bug you're talking about and if it's fixed or not.

Problem is that there is no bug report..


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100431/#review1021
-----------------------------------------------------------


On Jan. 21, 2011, 6:48 p.m., Thomas Richard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100431/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2011, 6:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> The AccountListModel passes the ModelTest with this patch
> 
> Thanks to Dominik Schmidt
> 
> 
> Diffs
> -----
> 
>   src/accounts-list-model.h fa67492ccd299574b5be244513a788e71f4799b3 
>   src/accounts-list-model.cpp b51e4f13aac186ecb53e9948546e1bc2c55c7f25 
> 
> Diff: http://git.reviewboard.kde.org/r/100431/diff
> 
> 
> Testing
> -------
> 
> Run ModelTest
> Add, edit and remove accounts
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110122/584c4288/attachment.htm