Review Request: Add account online-ness to the model.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100369/
-----------------------------------------------------------

(Updated Jan. 14, 2011, 9:27 p.m.)


Review request for Telepathy.


Changes
-------

Added review comments.


Summary
-------

Added 3 new roles to the account model. Connection as a string (online, connecting, disconnected), and as an icon.
Also added a string which says why the user is offline.
(because the account is disabled, because the password is wrong, network error etc)

Then created an Item Delegate for the accounts view that looks pretty.


Diffs (updated)
-----

  src/CMakeLists.txt 6ebed1268e697b9816ac0620467605c71324b3ef 
  src/account-item.h 75e24116c525e2315c9d8f622d3b2fcb1c5c1bb8 
  src/account-item.cpp 50afaa54c96ad51b6775f954cc180d1e12bbe96b 
  src/accounts-list-delegate.h PRE-CREATION 
  src/accounts-list-delegate.cpp PRE-CREATION 
  src/accounts-list-model.h 815719a08b1a3091d007a6ef30ab1131fd8b489c 
  src/accounts-list-model.cpp e0cf9bd13c7f1af8e8d936fe3e66af6db3aefdbc 
  src/kcm-telepathy-accounts.h 513db22457c2b77b4e36d54689d3b16810ac6854 
  src/kcm-telepathy-accounts.cpp c2579d2eb38c371f23e86f0a468f1ce90ef75b88 

Diff: http://git.reviewboard.kde.org/r/100369/diff


Testing
-------

Opened concurrently in both empathy and the accounts KCM, checked online state changed correctly, and that the "enabled" flag worked.

Tried accounts with network errors and incorrect passwords.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/100369/s/42/


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110114/69a9c609/attachment.htm