<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100369/">http://git.reviewboard.kde.org/r/100369/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2011, 9:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added review comments.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added 3 new roles to the account model. Connection as a string (online, connecting, disconnected), and as an icon.
Also added a string which says why the user is offline.
(because the account is disabled, because the password is wrong, network error etc)
Then created an Item Delegate for the accounts view that looks pretty.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened concurrently in both empathy and the accounts KCM, checked online state changed correctly, and that the "enabled" flag worked.
Tried accounts with network errors and incorrect passwords.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(6ebed1268e697b9816ac0620467605c71324b3ef)</span></li>
<li>src/account-item.h <span style="color: grey">(75e24116c525e2315c9d8f622d3b2fcb1c5c1bb8)</span></li>
<li>src/account-item.cpp <span style="color: grey">(50afaa54c96ad51b6775f954cc180d1e12bbe96b)</span></li>
<li>src/accounts-list-delegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/accounts-list-delegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/accounts-list-model.h <span style="color: grey">(815719a08b1a3091d007a6ef30ab1131fd8b489c)</span></li>
<li>src/accounts-list-model.cpp <span style="color: grey">(e0cf9bd13c7f1af8e8d936fe3e66af6db3aefdbc)</span></li>
<li>src/kcm-telepathy-accounts.h <span style="color: grey">(513db22457c2b77b4e36d54689d3b16810ac6854)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(c2579d2eb38c371f23e86f0a468f1ce90ef75b88)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100369/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100369/s/42/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/12/account_config_finished_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>