Review Request: Add ICQ config dialog

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100341/#review821
-----------------------------------------------------------


I don't see why you don't rename serverSettings to advancedSettings, and get rid of the advanced settings class. It's useful in Gabble as it holds the tab widget, and two files which are split up. 

Here it just has one widget in it, and passes all the data through without really doing a lot.


haze/icq-server-settings-widget.ui
<http://git.reviewboard.kde.org/r/100341/#comment606>

    Maximum should be 65535.


- David


On Jan. 9, 2011, 9:15 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100341/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 9:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add ICQ config dialog.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4a102d94a28c5ac927039ed63acc10c08b490ad4 
>   haze/CMakeLists.txt PRE-CREATION 
>   haze/Messages.sh PRE-CREATION 
>   haze/haze-account-ui-plugin.h PRE-CREATION 
>   haze/haze-account-ui-plugin.cpp PRE-CREATION 
>   haze/haze-icq-account-ui.h PRE-CREATION 
>   haze/haze-icq-account-ui.cpp PRE-CREATION 
>   haze/icq-advanced-options-widget.h PRE-CREATION 
>   haze/icq-advanced-options-widget.cpp PRE-CREATION 
>   haze/icq-main-options-widget.h PRE-CREATION 
>   haze/icq-main-options-widget.cpp PRE-CREATION 
>   haze/icq-main-options-widget.ui PRE-CREATION 
>   haze/icq-server-settings-widget.h PRE-CREATION 
>   haze/icq-server-settings-widget.cpp PRE-CREATION 
>   haze/icq-server-settings-widget.ui PRE-CREATION 
>   haze/kcmtelepathyaccounts_plugin_haze.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100341/diff
> 
> 
> Testing
> -------
> 
> Yes, works for me.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100341/s/38/
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110109/e67d3fe3/attachment-0001.htm