<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100341/">http://git.reviewboard.kde.org/r/100341/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't see why you don't rename serverSettings to advancedSettings, and get rid of the advanced settings class. It's useful in Gabble as it holds the tab widget, and two files which are split up.
Here it just has one widget in it, and passes all the data through without really doing a lot.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100341/diff/1/?file=6581#file6581line67" style="color: black; font-weight: bold; text-decoration: underline;">haze/icq-server-settings-widget.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <number>60000</number></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maximum should be 65535.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On January 9th, 2011, 9:15 p.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2011, 9:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add ICQ config dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, works for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4a102d94a28c5ac927039ed63acc10c08b490ad4)</span></li>
<li>haze/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-icq-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-icq-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-server-settings-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-server-settings-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/icq-server-settings-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/kcmtelepathyaccounts_plugin_haze.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100341/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100341/s/38/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/09/kde-telepathy-2_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>