Review Request - Telepathy Accounts KCM

[David]

I have yet more review requests! All thanks to havingan evening alone binge 
drinking tea.

in the accounts-kcm repository there are two branches 
"use_account_factory" makes use of AccountFactory and results in considerably 
easier to read code in the accounts model

"ui_fixes" contains a trivial margin fix. 


On Sunday 02 January 2011 21:28:11 David wrote:
> I made it all compile :-)
> 
> http://gitweb.kde.org/scratch/davidedmundson/telepathy-accounts-kcm.git
> 
> http://gitweb.kde.org/scratch/davidedmundson/telepathy-accounts-kcm-
> plugins.git/shortlog/refs/heads/fix_compile
> 
> The major change is not keeping pointers to ProtocolParameters and just
> copying them as the API seems to imply that's the better approach now.
> 
> Also the account plugin widgets simply return a QVariantMap of the
> protocolParameters instead of the custom map that didn't compile. Seems to
> all work, and unearthed quite a lot of other bugs that were present in the
> code.
> 
> From now on I'll work on making it all pretty and usable.
> 
> Dave
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy