Review Request - Telepathy Accounts KCM

David david at davidedmundson.co.uk
Sun Jan 2 22:28:11 CET 2011


I made it all compile :-)

http://gitweb.kde.org/scratch/davidedmundson/telepathy-accounts-kcm.git 

http://gitweb.kde.org/scratch/davidedmundson/telepathy-accounts-kcm-
plugins.git/shortlog/refs/heads/fix_compile

The major change is not keeping pointers to ProtocolParameters and just 
copying them as the API seems to imply that's the better approach now.

Also the account plugin widgets simply return a QVariantMap of the 
protocolParameters instead of the custom map that didn't compile. Seems to all 
work, and unearthed quite a lot of other bugs that were present in the code.

From now on I'll work on making it all pretty and usable.

Dave


More information about the KDE-Telepathy mailing list