Review Request: Provide pretty headers in the chat handler

David Edmundson kde at davidedmundson.co.uk
Sat Feb 26 02:49:40 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100753/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Provided pretty headers (i.e MyClassName which include myclassname.h). Removed a hack that included "../lib" in the application parts, and updated all non-lib code to use the new global includes.


Diffs
-----

  CMakeLists.txt d352370cdfccee02a10c42fc3addf7bb4c087777 
  adiumxtra-protocol-handler/CMakeLists.txt 16a3fe0304acb1480a325b27e4e4cc80664946e6 
  adiumxtra-protocol-handler/adiumxtraprotocolhandler.cpp 2dcefea97121de1ba27eceb19de6c48c692ba993 
  adiumxtra-protocol-handler/chatstyleinstaller.cpp 4dc9f3414181998f37f5c9d9a5d310d851f628dd 
  adiumxtra-protocol-handler/emoticonsetinstaller.cpp 0de3a98f1ca2def628a8dc1e2572ee68b99c1a9b 
  app/CMakeLists.txt f626914734b29aabcab32c10bbe50894848d7e0d 
  app/chatwindow.cpp fed4381f7a5a5d27587a5f5ba2e82d685a30173e 
  config/CMakeLists.txt 6d1e90016c35d8d4a36431382822934e1fe0fce8 
  config/mainwindow.h fee09e5b83fdde26b3ca46845fdf2dc47d71004c 
  config/mainwindow.cpp d3a29e80f87613b8e91a6cb981ffd3a9fb16da58 
  lib/AdiumThemeContentInfo PRE-CREATION 
  lib/AdiumThemeHeaderInfo PRE-CREATION 
  lib/AdiumThemeMessageInfo PRE-CREATION 
  lib/AdiumThemeStatusInfo PRE-CREATION 
  lib/AdiumThemeView PRE-CREATION 
  lib/CMakeLists.txt f31dbc79b7e3e3407ae7deecb5e8aef00755274a 
  lib/ChatStylePlistFileReader PRE-CREATION 
  lib/ChatWidget PRE-CREATION 
  lib/ChatWindowStyle PRE-CREATION 
  lib/ChatWindowStyleManager PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100753/diff


Testing
-------

Recompiled


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110226/9e49bcb5/attachment-0001.htm 


More information about the KDE-Telepathy mailing list